-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add troubleshooting guide for unexpected styles #28907
[docs] Add troubleshooting guide for unexpected styles #28907
Conversation
### Styles broken after migrating to v5 | ||
|
||
There are two reasons why the styles of the components may be migrated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this confusing. What are the actual symptoms? I have tried to follow the comments but I couldn't get a clear picture about what is going on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've rephrased it.
... | ||
``` | ||
|
||
In this `package-lock.json` file you can notice that `@mui/x-data-grid` has `@material-ui/core` in it's `peerDependencies`. You need to make sure to bump it to v5 so that it has `@mui/material` as a peer dependency instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to make sure to bump it to v5 so that it has
@mui/material
as a peer dependency instead.
Is this the only solution? Or is it really about the generateClassName
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the only solution?
I am trying to give info on a scenario where some dependency has @material-ui/core as a peer dependency. What other solution is available? This is one example, there can be other packages that have @material-ui/core as a dependency.
Or is it really about the
generateClassName
?
I am not following.
Co-authored-by: Siriwat K <[email protected]>
Adds troubleshooting guide for styles broken because of @material-ui/core being still installed after the migration to v5.
Reported in #28889, #24109 (comment), #24109 (comment)